[canvas] Color fixes + Storybook 5 #34075
Conversation
clintandrewhall
added
review
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💔 Build Failed |
|
Looks good, just a couple of suggestions with regards to the help and placeholder text. Change the helpText prop value to...
Change the placeholder text to then be more generic..
|
💚 Build Succeeded |
|
Please test this in IE. Last time a storybook PR went in, it broke IE for all of Kibana in master. |
💔 Build Failed |
|
@snide Which PR broke IE, and how? |
|
@clintandrewhall This was the fix we added #32159 after storybook was initially added. Just be careful with such a large dependency in Kibana. So if you move it around or update it in anyway, please check it out in various browsers since jenkins doesn't check this kind of stuff. |
|
@snide good to know, I appreciate the heads up on this. I figured my changes were safe because it was an x-pack dev dependency, but I can see where the problem came from. I tested my component in IE11, but I'll double-check Kibana as well. |
|
@snide Just checked: it loads and functions... let me know if there's anything specific you'd be concerned about... from the look of the last time this failed, I should see something nasty either starting or loading Kibana... but I'll ask all the same. Jenkins, test this. |
|
Nope. No worries. It's new too so breaks happen. Just want to make sure you check it out if you ever do a version bump like this one on it. |
💚 Build Succeeded |
| @@ -0,0 +1,3 @@ | |||
| .canvasColorPickerPopover__popover { | |||
| width: 250px; | |||
There was a problem hiding this comment.
Generally we try to avoid pixel values so that we know the designs are based off the EUI math and not brittle. Something like $euiSize * 15.
...canvas/public/components/color_picker_popover/__examples__/color_picker_popover.examples.tsx
Show resolved
Hide resolved
💔 Build Failed |
💚 Build Succeeded |
|
@ryankeairns I updated the help text. Let me know if this doesn't match your expectation.
|
💚 Build Succeeded |
(Fixes elastic#33734 elastic#33757 elastic#33735) This PR resolves issues with the `mini` color selector, the places the color picker was used, and removes complexity around color selection. It allows for CSS-based color strings while still ruling out duplicates in the color palette, and fixes bugs found recently. This PR also includes + modifies elastic#33896 and updates Storybook to v5. 
Summary
(Fixes #33734 #33757 #33735)
This PR resolves issues with the
minicolor selector, the places the color picker was used, and removes complexity around color selection. It allows for CSS-based color strings while still ruling out duplicates in the color palette, and fixes bugs found recently.This PR also includes + modifies #33896 and updates Storybook to v5.